fix: default namespace for cross-namespace ref validation #1828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelbarrera92
requested review from
aryan9600 and
stefanprodan
as code owners
angelbarrera92
force-pushed
the
issue-1827
branch
2 times, most recently
from
8f9ee1a to
174dafa
Compare
angelbarrera92
changed the title
Member
|
@angelbarrera92 can you please rebase with upstream main and force push |
When cross-namespace references are disabled, ensure that UpstreamRef, MetricTemplateRef, and AlertProviderRef default to the canary's namespace if their namespace field is empty. This aligns the validation logic with the rest of the controller and prevents false positives when the namespace is omitted. Fixes fluxcd#1827 Signed-off-by: Barrera, Angel <[email protected]>
angelbarrera92
force-pushed
the
issue-1827
branch
from
174dafa to
eeeac35
Compare
Contributor
Author
Done |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
===========================================
- Coverage 39.44% 28.95% -10.49%
===========================================
Files 287 287
Lines 22706 22891 +185
===========================================
- Hits 8956 6629 -2327
- Misses 12777 15537 +2760
+ Partials 973 725 -248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefanprodan
approved these changes
Oct 8, 2025
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @angelbarrera92 🏅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1827